Make import.meta.url be the file URL in SSR #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes SSR which previously was the mounted path to the file (just the path, so not a valid URL). It is now the actual file as a URL. This allows you to do relative lookups. This also adds support for importing via the `node:` prefix.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/HW3SVWpRyC5dJUYQRqJRyFFxgKUw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This fixes SSR which previously was the mounted path to the file (just the path, so not a valid URL). It is now the actual file as a URL. This allows you to do relative lookups.
This also adds support for importing via the
node:prefix.Testing
A test was added, but had to be skipped because Jest runs your code with the
vmmodule and that module has a bug that prevents usage ofimport(), which this code relies on.Docs
N/A