Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle runtime invalidation for proxy files #3449

Merged
merged 1 commit into from Jun 16, 2021
Merged

Conversation

matthewp
Copy link
Contributor

Changes

The file watcher reports the actual file name. We need to check for proxy files to properly invalidate the graph.

Testing

Test added, first runtime test.

Docs

N/A

The file watcher reports the actual file name. We need to check for proxy files to properly invalidate the graph.
@matthewp matthewp requested a review from a team as a code owner June 15, 2021 21:15
@vercel
Copy link

vercel bot commented Jun 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/Eka1JQQZEjs1dSGKYEVdUyZVaZ7U
✅ Preview: https://snowpack-git-invalidate-proxy-file-pikapkg.vercel.app

Copy link
Contributor

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good catch

@matthewp matthewp merged commit 7a1ae46 into main Jun 16, 2021
@matthewp matthewp deleted the invalidate-proxy-file branch June 16, 2021 12:03
matthewp added a commit to withastro/astro that referenced this pull request Jun 16, 2021
matthewp added a commit to withastro/astro that referenced this pull request Jun 16, 2021
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants