Add missing step in Vue tutorial #3421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed the copy on `line 129` so that it would match what's written in the code for clarity. - Add a section that makes it a bit more obvious that, in addition to what's changed in the `index.js` file, we'll also need to create a mounting element in the `index.html` for our Vue component.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/FsbTyBsRShYZ386f3TBAe8aSk3CX |
drwpow
reviewed
Jun 16, 2021
| + createApp(App).mount('#root'); | ||
| ``` | ||
|
|
||
| The page should now say "Learn Vue". Congratulations! You now have your first Vue component! | ||
| The page should now say "Welcome to my Vue app!". Congratulations! You now have your first Vue component! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
line 129so that it would match what's written in the code for clarity.index.jsfile, we'll also need to create a mounting element in theindex.htmlfor our Vue component.Testing
A change in the docs so I'm not sure if tests were necessary but I did pull everything locally and ran the
yarn test. CLI said that it passed 198 out of 198 tests.Docs
Doc/tutorial updated