Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PostCSS] Support glob property in dir-dependency messages #3404

Merged
merged 3 commits into from Jun 2, 2021

Conversation

bradlc
Copy link
Contributor

@bradlc bradlc commented Jun 2, 2021

Changes

Following on from #3309, this pull request updates @snowpack/plugin-postcss to add support for the glob property of dir-dependency messages registered by PostCSS plugins. Relevant documentation: https://github.com/postcss/postcss/blob/main/docs/guidelines/runner.md#3-dependencies

Testing

No tests added, discussed in #3309.

Docs

No docs added as this is not a user-facing change. The messages are created by PostCSS plugins and handled internally by @snowpack/plugin-postcss

@bradlc bradlc requested a review from a team as a code owner June 2, 2021 11:37
@vercel
Copy link

vercel bot commented Jun 2, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/6QnxcFvtcQPDBUhCsdyke6YwCqzg
✅ Preview: https://snowpack-git-fork-bradlc-postcss-glob-pikapkg.vercel.app

Copy link
Collaborator

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Was just about to comment on Node 12 compat but you already fixed it 🙂. I’m happy to merge this when tests pass.

@bradlc
Copy link
Contributor Author

bradlc commented Jun 2, 2021

Brilliant, thanks again @drwpow!

@drwpow drwpow merged commit bc56243 into FredKSchott:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants