Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow dynamic config in @snowpack/plugin-postcss #3344

Merged
merged 1 commit into from May 21, 2021

Conversation

drwpow
Copy link
Collaborator

@drwpow drwpow commented May 20, 2021

Changes

There may be instances in using @snowpack/plugin-postcss where you want to dynamically control plugins based on environment, etc. This PR adds the ability for plugin-postcss to accept an inline config rather than demanding a file on disk.

Testing

Test added. Also tested manually.

Docs

Plugin docs updated

@drwpow drwpow requested a review from a team as a code owner May 20, 2021 21:25
@vercel
Copy link

vercel bot commented May 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pikapkg/snowpack/9qTKK221XBfWAZMt53iQxjHhFRq9
✅ Preview: https://snowpack-git-postcss-dynamic-config-pikapkg.vercel.app

Copy link
Contributor

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two small nits.

plugins/plugin-postcss/worker.js Outdated Show resolved Hide resolved
plugins/plugin-postcss/README.md Outdated Show resolved Hide resolved
@drwpow drwpow merged commit 4f9da73 into main May 21, 2021
@drwpow drwpow deleted the postcss-dynamic-config branch May 21, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants