Chore: update snowpack.config.js to snowpack.config.mjs everywhere #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/DQqoCnw8FTrpUdmsQPxVTcGSC1CQ |
drwpow
force-pushed
the
snowpack-config-mjs
branch
from
9ed48d0
to
f17e98c
Compare
drwpow
force-pushed
the
snowpack-config-mjs
branch
2 times, most recently
from
c2ea0af
to
e0e8978
Compare
drwpow
force-pushed
the
snowpack-config-mjs
branch
from
e0e8978
to
e6496a5
Compare
drwpow
force-pushed
the
snowpack-config-mjs
branch
from
e6496a5
to
7997a94
Compare
matthewp
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#2834 finally added the ability to load ESM config files. But it’s something we didn’t promote in our docs. Let’s promote it more!
Testing
All
create-snowpack-apptemplates still build successfully, and the dev server starts successfully in the latest version of Node.However, our current test suite has to still use CommonJS for now, until either Jest gets ESM support or we move away from Jest.
Docs
This is a mostly-docs PR.