Expand devOptions.open documentation #3331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes <!-- What does this change, in plain language? --> <!-- Before/after screenshots may be helpful. --> Adds a snippet to the description of the devOptions.open config that explains you can also use a path to specify which browser to open ## Testing <!-- How was this change tested? --> <!-- DON'T DELETE THIS SECTION! If no tests added, explain why --> No, this is a change to documentation ## Docs Add note that path is a valid input to devOptions.open <!-- Was public documentation updated? --> <!-- DON'T DELETE THIS SECTION! If no docs added, explain why (e.g. "bug fix only") --> Yes, noted in change. Better describes the allowed input to the config option.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pikapkg/snowpack/F1hFMaWNqsBxQybRfpNpqwvrxB9e |
drwpow
reviewed
May 20, 2021
drwpow
approved these changes
May 20, 2021
Co-authored-by: Drew Powers <1369770+drwpow@users.noreply.github.com>
drwpow
approved these changes
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds a snippet to the description of the devOptions.open config that explains you can also use a path to specify which browser to open. I prefer to use firefox developer edition for web development and I couldn't any documentation that said how to. I did some messing around and found that paths work for devOptions.open (though you can't pass any flags) and it seemed like I could help someone else who might have a similar problem in the future.
Testing
No, this is a change to documentation
Docs
Yes, noted in change. Better describes the allowed input to the config option.