Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1177361: opentelemetry autoinstrumentation #1891

Open
drobert opened this issue Feb 29, 2024 · 3 comments
Open

SNOW-1177361: opentelemetry autoinstrumentation #1891

drobert opened this issue Feb 29, 2024 · 3 comments
Labels
feature status-triage_done Initial triage done, will be further handled by the driver team

Comments

@drobert
Copy link

drobert commented Feb 29, 2024

What is the current behavior?

None, seemingly. Using opentelemetry autoinstrumentation along with included related packages (see https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/instrumentation ) a python application can get tracing data and timing for most network-related actions: http requests, database access, aws operations, etc. but snowflake is invisible.

What is the desired behavior?

Provide common database opentelemetry information if there's an active trace such that the query and timing (and calls) appear in auto-instrumented opentelemetry traces.

Barring that, documentation on how to manually collect trace information for snowflake-connector while otherwise utilizing automatic instrumentation would be helpful.

How would this improve snowflake-connector-python?

Improved observability of any python application utilizing snowflake

References and other background

No response

@github-actions github-actions bot changed the title opentelemetry autoinstrumentation SNOW-1177361: opentelemetry autoinstrumentation Feb 29, 2024
@sfc-gh-dszmolka
Copy link

hi and thank you for raising this request with us ! can you please take a look at the Emitting Trace Events in Python to see if it is at least partially what can help you move forward ?

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Mar 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Mar 11, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage Issue is under initial triage and removed status-triage_done Initial triage done, will be further handled by the driver team labels Mar 11, 2024
@drobert
Copy link
Author

drobert commented Mar 12, 2024

hi and thank you for raising this request with us ! can you please take a look at the Emitting Trace Events in Python to see if it is at least partially what can help you move forward ?

I did not feel this documentation was very helpful for this issue for two main reasons:

  1. this ticket is about automatic instrumentation. I had to do zero work to get queries traces in my existing application against my relational datastore (and other remote sources, see the instrumentation link in the issue description); the request here is to support the automatic instrumentation of an app which is successfully using auto-instrumentation for the rest of its trace collection.
  2. this is in the 'functions and procedures' section of the documentation. my application is running outside of snowflake but connecting to it using the python-connector. The documentation very heavily implies this is for python code running inside snowflake ( as a function/UDF )

@sfc-gh-dszmolka
Copy link

thanks for checking still, and for providing further insight into the use-case. we'll consider this requirement for enhancement for the future.

@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed status-triage Issue is under initial triage labels Mar 13, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka removed their assignment Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Development

No branches or pull requests

2 participants