SNOW-897499: Throw ReauthenticationRequest error instead of ProgrammingError

[vgutkovsk]

What is the current behavior?

Currently if ReauthenticationRequest gets raised, it gets caught by the library and instead ProgrammingError gets raised.
network.py

except ReauthenticationRequest as ex:
    if self._connection._authenticator != EXTERNAL_BROWSER_AUTHENTICATOR:
        raise ex.cause
    ret = self._connection._reauthenticate()

Both errors would be captured in logs, but there's no way to determine in code if the error is caused by reauthentication request.

What is the desired behavior?

Desired behaviour is either raising ProgrammingError but like this: raise ex.cause from ex. Or throw ReauthenticationRequest error instead.

How would this improve snowflake-connector-python?

This would allow users to catch ReauthenticationRequest separately from ProgrammingError and have a different logic to handle one or the other.

References and other background

I have this code for running queries in Snowflake.

try:
    snowflake.execute(query)
except (snowflake.connector.InterfaceError,
        snowflake.connector.OperationalError) as exc: # these errors can be handled by recreating connection
    logging.error(exc)
    snowflake.recreate_connection()
    snowflake.execute(query)

But unfortunately this code fails when ProgrammingError gets raised. I can see that most of the times ProgrammingError gets raised in situations when recreating connection would not help. However, it's not the case when it gets raised because of ReauthenticationRequest. To handle this I need to do the following:

try:
    snowflake.execute(query)
except (snowflake.connector.InterfaceError,
        snowflake.connector.OperationalError,
        snowflake.connector.errors.ProgrammingError) as exc:
    if isinstance(snowflake.connector.errors.ProgrammingError, exc) and 'Authentication token has expired' not in exc.msg:
        raise
    logging.error(exc)
    snowflake.recreate_connection()
    snowflake.execute(query)

This code is not very stable because it relies on the message in the error.

[sfc-gh-dszmolka]

hi and thank you for raising this request! we'll consider it as a possible future improvement and of course if you have the capacity to help out and submit a PR, that would be also appreciated!