Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mastodon login and interactive publish broken due to Mastodon/doorkeeper OAuth bug #911

Closed
troutcolor opened this issue Jan 19, 2020 · 23 comments
Labels

Comments

@troutcolor
Copy link

troutcolor commented Jan 19, 2020

Hi,
I had this working on my blog posting to mastodon.social using the Syndication Links plugin and then it stopped working.
I not sure if the bridgy log will help or not.

Trying on the bridgy site, I get to this mastodon page not sure if that will work? This says "We're sorry, but something went wrong on our end."

Hopefully that makes some sort of sense?
Cheers

john

@snarfed
Copy link
Owner

snarfed commented Jan 19, 2020

hey, sorry for the trouble! could you try disabling and re-enabling publishing on https://brid.gy/mastodon/@johnjohnston@mastodon.social and see if it works then? i've seen this scope issue with mastodon before, but i'm still trying to track it down.

@troutcolor
Copy link
Author

Hi, thanks. I just tried that and resubmitted a post through the bridgy page. I got the same result.
Is there any other information I can send that might help?

Cheers
John

@snarfed
Copy link
Owner

snarfed commented Jan 19, 2020

thanks for trying! that's all i need, i'll investigate.

@snarfed
Copy link
Owner

snarfed commented Jan 20, 2020

oh god, also, i just noticed the mastodon page link you originally posted included bridgy's client secret for mastodon.social. 😐 i'll reset that. please be careful when posting URLs from login and auth flows! (basically, don't unless you know what you're doing. 😁)

@troutcolor
Copy link
Author

oh god, also, i just noticed the mastodon page link you originally posted included bridgy's client secret for mastodon.social. 😐 i'll reset that. please be careful when posting URLs from login and auth flows! (basically, don't unless you know what you're doing. 😁)

I certainly don’t know what I am doing. Thanks!

@snarfed
Copy link
Owner

snarfed commented Jan 21, 2020

i reproduced this tonight and suspect something wrong on mastodon's end: mastodon/mastodon#12915 . let's see what they say.

@snarfed snarfed changed the title publishing to mastoton stopped working publishing to mastoeon stopped working Jan 27, 2020
@snarfed snarfed changed the title publishing to mastoeon stopped working publishing to mastodon stopped working Jan 27, 2020
@joebuhlig
Copy link

I might have a related issue. I continue to get the yellow pause icon. I can revoke access on Mastodon, log out of Bridgy, and then reinstate everything. But the issue returns. It seems like it's an authorization issue on Mastodon's side, but I can't find any errors to share.

@snarfed
Copy link
Owner

snarfed commented Jan 28, 2020

oops, sorry @joebuhlig! my fault, looks like an unrelated bug. thanks for the nudge! i think i've fixed it now, mind trying again?

@joebuhlig
Copy link

Just tried the yellow pause button again. It asked for an authorization and then after a couple minutes returned with the pause button again. Do I need to revoke, log out, and start over?

@snarfed
Copy link
Owner

snarfed commented Jan 28, 2020

no, sorry, my fix needed a bit more to it. deployed that now and tested locally. mind trying again? thanks for your patience!

@joebuhlig
Copy link

Bingo! Thank you much!

snarfed added a commit that referenced this issue Jan 28, 2020
for #911 (comment) . we fetch notifs for @-mentions, and we filter out non-public toots ourselves, but we don't yet _ask_ for only public toots. TODO: do that.

thanks for reporting @joebuhlig!
@snarfed snarfed changed the title publishing to mastodon stopped working interactive publishing to mastodon stopped working Feb 10, 2020
@hs0ucy
Copy link

hs0ucy commented Feb 19, 2020

I have the same problem. I tried with the form, then with cURL.

`curl -d 'source=https://hugo.soucy.cc/note/2020/02/lost-connection-to-the-earth.html&target=https://brid.gy/publish/mastodon' \

https://brid.gy/publish/webmention
{
"error":"Couldn't find link to brid.gy/publish/mastodon"`

I disconnected and reconnected but the result is the same.

My mastodon instance is not mastodon.social but mastodon.sdf.org.

Thanks

1 similar comment
@hs0ucy
Copy link

hs0ucy commented Feb 19, 2020

I have the same problem. I tried with the form, then with cURL.

`curl -d 'source=https://hugo.soucy.cc/note/2020/02/lost-connection-to-the-earth.html&target=https://brid.gy/publish/mastodon' \

https://brid.gy/publish/webmention
{
"error":"Couldn't find link to brid.gy/publish/mastodon"`

I disconnected and reconnected but the result is the same.

My mastodon instance is not mastodon.social but mastodon.sdf.org.

Thanks

@snarfed
Copy link
Owner

snarfed commented Feb 19, 2020

@hs0ucy that looks like a different problem. as the error message says, your post needs to link to https://brid.gy/publish/mastodon . see https://brid.gy/about#webmentions

@hs0ucy
Copy link

hs0ucy commented Feb 19, 2020

@hs0ucy that looks like a different problem. as the error message says, your post needs to link to https://brid.gy/publish/mastodon . see https://brid.gy/about#webmentions

Oh, you're right ... In my template i had https://fed.brid.gy 👎 :/

Thanks!

@jee-r
Copy link

jee-r commented Feb 20, 2020

@GitHub

Hello, Is there a cli way to verify if bridgy is connected to mastodon instance and if is not the case to reconnect it ?

I was thinking something like authorize it with an app https://mastodon.social/settings/applications/new

It’s can be a workaround to avoid unintended disconnection

Thank’s

#bridgy #disconnection #mastodon #cli

(Originally published at: https://jeer.fr/micro/1582197847)

@snarfed
Copy link
Owner

snarfed commented Feb 20, 2020

@jee-r hmm! are you seeing your bridgy mastodon account get repeatedly disconnected? is that related to the interactive publishing problem here?

@jee-r
Copy link

jee-r commented Feb 20, 2020

@snarfed i don't know if it's a real disconnection but sometime when i try to publish i get the error message out of scope when it's happened i need to disconnect from bridgy, remove the bridgy's app authorization in mastodon's settings and reconnect again. You are right it's may be more related to #894 than this issue, if it's happened again i'll report rather there.

@snarfed snarfed added the publish label Jul 4, 2020
@isellsoap
Copy link

isellsoap commented Jul 9, 2020

I have the same error since a few weeks now (see a recent log with the authorization error).

The set up on my side should be correct (I think). When trying to send a webmention to Mastodon via Bridgy, the Mastodon Bridgy page shows the pause button ("This account was disconnected on Mastodon's end. Click to reconnect it!"). If I repeat the process after reconnecting the account, the same pattern occurs.

@snarfed snarfed changed the title interactive publishing to mastodon stopped working Mastodon: bring back interactive publishing (blocked on mastodon bug) Feb 4, 2021
@snarfed
Copy link
Owner

snarfed commented Sep 2, 2021

I looked at this a bit again recently. Looks like the Mastodon bug is a URL length limit that the OAuth redirect URL hits on their end. It's a bit inconsistent, but definitely there, across instances. Details in mastodon/mastodon#12915 😐

@snarfed snarfed changed the title Mastodon: bring back interactive publishing (blocked on mastodon bug) Mastodon login and interactive publish broken due to Mastodon/doorkeeper OAuth bug Aug 13, 2022
@snarfed
Copy link
Owner

snarfed commented Aug 13, 2022

Discussion is now in doorkeeper-gem/doorkeeper#1554, tentative conclusion is that the issue is in doorkeeper. Still not much more movement though. 😐

@snarfed
Copy link
Owner

snarfed commented Jan 4, 2023

I'm going to try to work around this by shortening the redirect URL on Bridgy's side. indieweb.social and mastodon.art aren't reproducing it right now, but mas.to is.

snarfed added a commit to snarfed/oauth-dropins that referenced this issue Jan 11, 2023
@snarfed
Copy link
Owner

snarfed commented Jan 11, 2023

It worked! Specifically snarfed/oauth-dropins@1e987be, snarfed/oauth-dropins@0ba0f71. I think we're back in business with Mastodon login and interactive publish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants