Re-port #90 #194
Merged
Re-port #90 #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jens Reidel <adrian@travitia.xyz>
daniel-abramov
approved these changes
Oct 14, 2021
There was a problem hiding this comment.
Thanks! LGTM.
@jxs, if you agree with the changes, then we can merge it. I could then close the 2 leftovers that are superseded by this one.
jxs
approved these changes
Oct 16, 2021
This was referenced Dec 8, 2021
gregates
pushed a commit
to gregates/tokio-tungstenite
that referenced
this pull request
Feb 24, 2024
…-roots-0.22.0 Update webpki-roots requirement from 0.21.0 to 0.22.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially a re-port of #90 to the latest version of tokio-tungstenite - the PR has merge conflicts and I assume that's why it hasn't been touched at all. I'm hoping that this re-port will make it possible to apply the changes. I also removed the unused
async-awaitfeature on futures-util.Would love to see this merged since most other libraries - e.g. async-tungstenite or hyper - moved away from pin-project and this allows for much faster compile times.
As mentioned in #90, this might be a breaking change, but I am not sure. It does work fine for my existing uses and the examples, however.