Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow choosing rustls certs through flags #184

Merged
merged 1 commit into from Aug 13, 2021

Conversation

dnaka91
Copy link
Contributor

@dnaka91 dnaka91 commented Aug 10, 2021

This aligns the feature flags with latest changes from tungstenite-rs. It allows to pick either native OS certs or the webpki-roots embedded certs (or both) to be used for rustls.

The PR is a draft as the latest changed from tungstenite are not published as new release yet.


@daniel-abramov
Copy link
Member

Thanks for the great change once again :) I've recently published the new version of the tungstenite-rs, so feel free to update it.

P.S.: I have however forgotten to merge the PR for the package size before publishing the crate 🤦‍♂️ , but I hope it's not a big deal, we'll benefit from it from the next release on ;)

@dnaka91 dnaka91 marked this pull request as ready for review August 13, 2021 06:40
@dnaka91
Copy link
Contributor Author

dnaka91 commented Aug 13, 2021

All updated and ready 👍

Copy link
Member

@daniel-abramov daniel-abramov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's nice!

@daniel-abramov daniel-abramov merged commit 171a452 into snapview:master Aug 13, 2021
@dnaka91 dnaka91 deleted the rustls-roots branch August 14, 2021 00:39
gregates pushed a commit to gregates/tokio-tungstenite that referenced this pull request Feb 24, 2024
Add `From<ProtocolError>` impl for `Error`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants