Fix Autobahn Scripts #165
Merged
Fix Autobahn Scripts #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniel-abramov
force-pushed
the
fix-autobahn
branch
2 times, most recently
from
5d14e85
to
6b59e70
Compare
strohel
requested changes
Apr 21, 2021
strohel
reviewed
Apr 22, 2021
According to the documentation from the Autobahn Suite GitHub page, it seems like they do not support Python 3 which is currently the default Python version used with our GitHub Actions. The simplest way to workaround it properly seems to be using the Docker image that the maintainers of the project suggest to use for running the suite. This is more future-proof way that we should rely upon. This commit also removes some redundant steps that are not required.
daniel-abramov
force-pushed
the
fix-autobahn
branch
from
6b59e70
to
12e3dca
Compare
Yeah, I also thought about that. I still enjoy the elegance and conciseness of Travis (compare it to GitHub Actions job definition that is much longer), but having both at the same time does not seem like a reasonable use of resources. Though we don't use Github Actions in |
daniel-abramov
added a commit
to snapview/tungstenite-rs
that referenced
this pull request
Apr 22, 2021
See snapview/tokio-tungstenite#165 for more details.
strohel
approved these changes
Apr 23, 2021
daniel-abramov
added a commit
to snapview/tungstenite-rs
that referenced
this pull request
Apr 23, 2021
Use Autobahn Suite from Docker, symmetrical to snapview/tokio-tungstenite#165
a-miyashita
pushed a commit
to givery-technology/tungstenite-rs
that referenced
this pull request
Jul 20, 2023
See snapview/tokio-tungstenite#165 for more details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for more details.
NOTE: I also noticed that one of the files with results for Autobahn was [apparently blindly] copied in our repositories and is not used neither in
tungstenite-rsnor intokio-tungstenite. I tried to include this small clean up in this PR (could not hold myself leaving it as is), but I plan to submit a separate PR to do the same intungstenite-rs. Additionally, there is a possibility to remove the code duplication for the tests that we do for Autobahn and to extract the common part, so thattokio-tungsteniteandtungstenite-rsdo not need to contain the same code.