Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of different types of errors on a client side #102

Open
EverlastingBugstopper opened this issue May 12, 2020 · 2 comments
Open

Comments

@EverlastingBugstopper
Copy link

EverlastingBugstopper commented May 12, 2020

Right now there is a lot of unwrap in the client example. It would be nice to show how to handle different tungstenite::Errors that can crop up.

edit: i'm trying to do this myself

@daniel-abramov
Copy link
Member

Hm, while we can add some error handling, the way the error is handled depends on a use case. We tried to document what each error means. Should we probably extend our documentation, so that it's clear what each error means?

Do you find the error description for one or another error type confusing? If so, would you please point to them, so that we can clarify them?

@daniel-abramov daniel-abramov changed the title show error handling in client example Handling of different types of errors on a client side May 19, 2020
@EverlastingBugstopper
Copy link
Author

EverlastingBugstopper commented May 19, 2020

No it's not necessarily about what errors crop up, but how to handle them in the first place. In the example directory there are a bunch of different use cases (client/server) and it would be awesome to show how to handle errors there for those specific use cases instead of calling unwrap. Does that make sense?

example of unwrap in client example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants