Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete DAG with checkpoints #2822

Open
fgvieira opened this issue Apr 18, 2024 · 3 comments
Open

Incomplete DAG with checkpoints #2822

fgvieira opened this issue Apr 18, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@fgvieira
Copy link
Contributor

Snakemake version

v8.10.7

Describe the bug

DAG is incomplete when there are checkpoints, since it only plots the DAG for the rules upstream of the checkpoint.

Minimal example

On test snakemake/tests/test_checkpoint_allowed_rules, if we run snakemake c --dag | dot -Tsvg > dag.svg, we get the DAG:

dag

Where I think we would also expect rule b going into rule c.

@fgvieira fgvieira added the bug Something isn't working label Apr 18, 2024
@cademirch
Copy link
Contributor

Seems slightly related to #2824. I think this makes sense since B doesn't exist in the DAG until after A has been run.

@fgvieira
Copy link
Contributor Author

Yes, but then it should work if a has been run, but it does not. As it is now:

  • if a has not been run: a -> c
  • if a has bee run: b -> c

So it is never possible to get the full DAG.

@cademirch
Copy link
Contributor

Ah. I see what you're saying. I agree you should get the full dag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants