fix: allow script directive to take pathlib Path #1869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
johanneskoester
approved these changes
Sep 21, 2022
johanneskoester
pushed a commit
that referenced
this pull request
Sep 26, 2022
🤖 I have created a release *beep* *boop* --- ## [7.14.1](v7.14.0...v7.14.1) (2022-09-23) ### Bug Fixes * allocation of local ssds in k8s tests ([#1870](#1870)) ([d0de4dc](d0de4dc)) * allow script directive to take pathlib Path ([#1869](#1869)) ([12cdc96](12cdc96)) * catch errors in remote.AUTO provider list ([#1834](#1834)) ([c613ed2](c613ed2)) * consistently use text output in conda shell commands and various little fixes for failing test cases due to conda package changes ([#1864](#1864)) ([4234fe7](4234fe7)) * declare associative arrays ([#1844](#1844)) ([90ae449](90ae449)) * fix falsely triggered reruns if input files are obtained via workflow.source_path() ([#1862](#1862)) ([2dc2e6a](2dc2e6a)) * fixed typos ([#1847](#1847)) ([a1e49b6](a1e49b6)) * k8s container volume mounts as list ([#1868](#1868)) ([5c54df3](5c54df3)) * None type error when invoking Workflow object manually ([#1731](#1731)) ([dc45ccb](dc45ccb)) * request disk_mb resource from k8s ([#1858](#1858)) ([f68f166](f68f166)) * respect shebang lines in post-deploy scripts (see deployment docs) ([#1841](#1841)) ([c26c4b6](c26c4b6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
2 tasks
johanneskoester
pushed a commit
that referenced
this pull request
Oct 14, 2022
### Description In #1869 I added the ability to use a `pathlib.Path` object in the `script` directive. When generating a report where a rule has a Path in the script directory, this function was causing snakemake to error as it assumes the path is a string. This PR makes it explicitly a string. ### QC <!-- Make sure that you can tick the boxes below. --> * [ ] The PR contains a test case for the changes or the changes are already covered by an existing test case. * [ ] The documentation (`docs/`) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows the
scriptdirective to accept apathlib.Pathobject.QC
docs/) is updated to reflect the changes or this is not necessary (e.g. if the change does neither modify the language nor the behavior or functionalities of Snakemake).