Error refactor, part 2: Remove Error enum. #730
Merged
+1,489
−2,047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assembler no longer needs the total buffer size, added range indices can be as high as needed. - Fixes quadratic run time when adding a range that overlaps with many existing ranges.
Dirbaio
force-pushed
the
errors
branch
5 times, most recently
from
68be61d to
e649abd
Compare
Currently it's not working properly, because you can call it when the UDP payload is not written yet to the buffer. I've changed it to not be able to, and clarified in docs that it's for internal-packet-use only. It's only used for 6lowpan decompression, and in that case we don't want to calculate and then later check the checksum.
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes work started on #617, see there for motivation.
Depends on #726