Backport several fixes to 0.8 #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to get tests to run on recent versions of Rust.
If we have an incomplete packet to send and the socket has been closed then send it. Without this change (with nagle enabled) we wait for the penultimate packet in the stream to be acked before sending the final packet even if there's plenty of space in the window.
|
Thanks! |
|
0.8.2 out |
|
Perfect! Thank you so much for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #662 and #665 to the 0.8 branch, which are the two commits we're using in our fork of smoltcp (as discussed in #662). I've gone through the remaining commits on master and don't see anything big which stands out, but happy to take a look at anything else important!