Simplify using lock_arc #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The future returned by lock_arc would already resolve to a MutexGuardArc that kept the Arc<Mutex> alive. Unfortunately, sometimes one needs to store the future itself, not the MutexGuardArc and the future had a reference to the Arc<Mutex>. With this patch, the future itself also has a Arc<Mutex>.
|
For comparison, tokio's mutex has the api: note that it takes self by value. |
|
Published in 2.5.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The future returned by lock_arc would already resolve to a
MutexGuardArc that kept the Arc alive. Unfortunately, sometimes
one needs to store the future itself, not the MutexGuardArc and the
future had a reference to the Arc.
With this patch, the future itself also has a Arc.