Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JMESPath type checker completeness #2003

Open
0marperez opened this issue Oct 6, 2023 · 0 comments
Open

JMESPath type checker completeness #2003

0marperez opened this issue Oct 6, 2023 · 0 comments
Labels
feature-request A feature should be added or improved.

Comments

@0marperez
Copy link

The jmespath type checker is not complete

For example:

FUNCTIONS.put("sort", new FunctionDefinition(ARRAY, isArray));

The sort function type check is not looking at type of array when the jmespath specification says it should be an array of string or number only.

FUNCTIONS.put("sort_by", new FunctionDefinition(ARRAY, isArray, isType(RuntimeType.EXPRESSION)));

Same for the sort_by function, the expression should only result in a string or number.

I see TODO's in there but no issue created to keep track of it. It'd be good to have this completed as it could cause invalid models.

@JordonPhillips JordonPhillips added the feature-request A feature should be added or improved. label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

No branches or pull requests

2 participants