Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protocol test InputAndOutputWithTimestampHeaders contains quotes for RestJSON but not for RestXml #1015

Closed
trivikr opened this issue Dec 10, 2021 · 1 comment
Closed

Protocol test InputAndOutputWithTimestampHeaders contains quotes for RestJSON but not for RestXml #1015

trivikr opened this issue Dec 10, 2021 · 1 comment

Comments

@trivikr
Copy link
Contributor

trivikr commented Dec 10, 2021

Links to the code

RestJSON https://github.com/awslabs/smithy/blob/78a3ac958ea442695cf66ad0f5808768e1f553bf/smithy-aws-protocol-tests/model/restJson1/http-headers.smithy#L108-L121

RestXML: https://github.com/awslabs/smithy/blob/75928a7c69b2a156382b5d8bc87a6991f5fea64e/smithy-aws-protocol-tests/model/restXml/http-headers.smithy#L93-L106

Observation

This appears to be a bug, as the behavior for the list of timestamps should be same across protocols

Additional Context
@gosar gosar mentioned this issue Dec 20, 2021
Merged
@gosar
Copy link
Contributor

gosar commented Dec 20, 2021

In #1023 reverted escaping of timestamp header in restJson1. Now restJson1 and restXml are same.

@gosar gosar closed this as completed Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gosar @trivikr