Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Runs and fails for updates of main branch of forks #3519

Open
iamjpotts opened this issue Mar 27, 2024 · 2 comments
Open

CI Runs and fails for updates of main branch of forks #3519

iamjpotts opened this issue Mar 27, 2024 · 2 comments
Labels
bug Something isn't working ops Improves our operations and release process

Comments

@iamjpotts
Copy link
Contributor

Is it desirable for the GitHub workflows to run on a main branch of forks?

For example, this is a failing run on the main branch of my fork. The run of build-and-deploy-the-docs was triggered by syncing my main branch with this repo's main branch.

https://github.com/iamjpotts/aws-smithy-rs/actions/runs/8454159377/job/23158537415.
@jdisanti
Copy link
Collaborator

It's definitely not intended to run on the main branch in forks.

@jdisanti jdisanti added bug Something isn't working ops Improves our operations and release process labels Mar 27, 2024
@iamjpotts
Copy link
Contributor Author

Link to the CI runs that are triggering from main of my fork:

https://github.com/iamjpotts/aws-smithy-rs/actions

@iamjpotts iamjpotts mentioned this issue Apr 21, 2024
Merged
2 tasks
github-merge-queue bot pushed a commit that referenced this issue Apr 22, 2024
@iamjpotts
CI: Only allow daily credentials verification to run on smithy-lang/ …
c717874 
…repo (#3597)

## Motivation and Context

The CI job that checks CI credentials fails when run on forks, resulting
in daily job failure alerts in forks.

Example failure:
https://github.com/iamjpotts/aws-smithy-rs/actions/runs/8768654532

See #3519.

## Description

For the `Daily Credentials Verification` workflow, add a condition on
each of its jobs so that they will only run for the
`smithy-lang/smithy-rs` repo and not any forks.


## Testing

No code changes.

## Checklist
<!--- If a checkbox below is not applicable, then please DELETE it
rather than leaving it unchecked -->
- [X] I have updated `CHANGELOG.next.toml` if I made changes to the
smithy-rs codegen or runtime crates
- [X] I have updated `CHANGELOG.next.toml` if I made changes to the AWS
SDK, generated SDK code, or SDK runtime crates

----

CI only; no change log entry required.

_By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice._

Signed-off-by: Joshua Potts <8704475+iamjpotts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working ops Improves our operations and release process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jdisanti @iamjpotts