Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update example code to use write_all_buf #349

Closed
rcoh opened this issue May 1, 2021 · 3 comments
Closed

Update example code to use write_all_buf #349

rcoh opened this issue May 1, 2021 · 3 comments
Labels
good first issue Good for newcomers

Comments

@rcoh
Copy link
Collaborator

rcoh commented May 1, 2021

write_all_buf was added to AsyncWriteExt which is a one-liner for writing a buf to a file directly. Suggest people use this in example code in ByteStream as well as in examples like Polly synthesize speech.

note: requires new Tokio release containing tokio-rs/tokio#3737
@rcoh rcoh added the good first issue Good for newcomers label May 1, 2021
@rcoh
Copy link
Collaborator Author

rcoh commented May 14, 2021

Tokio 1.6.0 has landed with the new API 🎉

@LMJW LMJW mentioned this issue May 24, 2021
Merged
@LMJW
Copy link
Contributor

LMJW commented May 24, 2021

Hi @rcoh. Just created a small PR for updating the examples. Please let me know if you have any feedbacks. Thanks :)

@rcoh
Copy link
Collaborator Author

rcoh commented May 24, 2021

Thanks @LMJW!

@rcoh rcoh closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rcoh @LMJW