diff --git a/codegen-server-test/build.gradle.kts b/codegen-server-test/build.gradle.kts index 693ed13c82..2dbeebca0a 100644 --- a/codegen-server-test/build.gradle.kts +++ b/codegen-server-test/build.gradle.kts @@ -61,12 +61,7 @@ val allCodegenTests = "../codegen-core/common-test-models".let { commonModels -> "constraints", imports = listOf("$commonModels/constraints.smithy"), ), - CodegenTest( - "aws.protocoltests.restjson#RestJson", - "rest_json", - // TODO(https://github.com/awslabs/smithy-rs/issues/1401) `@uniqueItems` is used. - extraConfig = """, "codegen": { "ignoreUnsupportedConstraints": true } """, - ), + CodegenTest("aws.protocoltests.restjson#RestJson", "rest_json"), CodegenTest( "aws.protocoltests.restjson#RestJsonExtras", "rest_json_extras", @@ -75,26 +70,18 @@ val allCodegenTests = "../codegen-core/common-test-models".let { commonModels -> CodegenTest( "aws.protocoltests.restjson.validation#RestJsonValidation", "rest_json_validation", + // `@range` trait is used on floating point shapes, which we deliberately don't want to support. + // See https://github.com/awslabs/smithy-rs/issues/1401. extraConfig = """, "codegen": { "ignoreUnsupportedConstraints": true } """, ), CodegenTest("aws.protocoltests.json10#JsonRpc10", "json_rpc10"), - CodegenTest( - "aws.protocoltests.json#JsonProtocol", - "json_rpc11", - extraConfig = """, "codegen": { "ignoreUnsupportedConstraints": true } """, - ), + CodegenTest("aws.protocoltests.json#JsonProtocol", "json_rpc11"), CodegenTest( "aws.protocoltests.misc#MiscService", "misc", imports = listOf("$commonModels/misc.smithy"), - // TODO(https://github.com/awslabs/smithy-rs/issues/1401) `@uniqueItems` is used. - extraConfig = """, "codegen": { "ignoreUnsupportedConstraints": true } """, - ), - CodegenTest( - "com.amazonaws.ebs#Ebs", "ebs", - imports = listOf("$commonModels/ebs.json"), - extraConfig = """, "codegen": { "ignoreUnsupportedConstraints": true } """, ), + CodegenTest("com.amazonaws.ebs#Ebs", "ebs", imports = listOf("$commonModels/ebs.json")), CodegenTest("com.amazonaws.s3#AmazonS3", "s3"), CodegenTest( "com.aws.example.rust#PokemonService", diff --git a/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ValidateUnsupportedConstraints.kt b/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ValidateUnsupportedConstraints.kt index 3a6cdabcd0..26f298c191 100644 --- a/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ValidateUnsupportedConstraints.kt +++ b/codegen-server/src/main/kotlin/software/amazon/smithy/rust/codegen/server/smithy/ValidateUnsupportedConstraints.kt @@ -262,7 +262,7 @@ fun validateUnsupportedConstraints( .map { (shape, rangeTrait) -> UnsupportedRangeTraitOnShape(shape, rangeTrait as RangeTrait) } .toSet() - // 5. `@uniqueItems` cannot reach a map shape. + // 4. `@uniqueItems` cannot reach a map shape. // See https://github.com/awslabs/smithy/issues/1567. val mapShapeReachableFromUniqueItemsListShapeSet = walker .walkShapes(service)