Set minimum Go version to 1.16 #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimsht
reviewed
Oct 26, 2021
go.sum
Outdated
| @@ -1,12 +1,578 @@ | |||
| github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1 h1:EGx4pi6eqNxGaHF6qqu48+N2wcFQ5qg5FXgOdqsJ5d8= | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
There was a problem hiding this comment.
This looks super odd... can you figure out how all the cloudy stuff appears here? Does any of Convey's dependencies depend on Cloud?
There was a problem hiding this comment.
I believe this is all indirect via gopherjs (which itself is indirect via gls). Going to be a while before we can remove these :(
|
Note; I think we can remove the x/tools dependency later, but the gls dependency is going to be hard to fix |
|
Updated to ONLY bump the version on the assertions library; The other dependencies will need to be whittled away carefully. |
This also selects a stable version for smartystreets/assertions.
vadimsht
approved these changes
Oct 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also selects stable versions for go.mod dependencies.
Unfortunately, the gopherjs dependency is an indirect dependency
of gls, which supports gopherjs specifically for the purpose of
allowing GoConvey to work with gopherjs applications.