Stop compiling and testing packages in testdata #488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riannucci
reviewed
Feb 20, 2018
| hasImportCycle := testFilesImportTheirOwnPackage(folder.Path) | ||
| packageList = append(packageList, contract.NewPackage(folder, hasImportCycle)) | ||
| } | ||
| return packageList | ||
| } | ||
|
|
||
| func isInsideTestdata(folder *messaging.Folder) bool { |
There was a problem hiding this comment.
Can we add a comment to this function explaining the situation?
riannucci
approved these changes
Feb 20, 2018
Go tooling, including `go test` treat the testdata directory as an opaque directory containing data for tests. Unfortunately, goconvey would treat go source files inside testdata or its subdirectories as creating a package, causing divergence in behavior from Go tooling. This commit causes goconvey to not treat anything inside the testdata directory or subdirectories as a package without removing them from the watch list. This creates behavioral parity with Go tooling, but means a change in testdata will still cause tests to be rerun.
CtrlZvi
force-pushed
the
ignore_testdata_packages
branch
from
5665823
to
6205260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go tooling, including
go testtreat the testdata directory as an opaquedirectory containing data for tests. Unfortunately, goconvey would treat go
source files inside testdata or its subdirectories as creating a package,
causing divergence in behavior from Go tooling.
This commit causes goconvey to not treat anything inside the testdata
directory or subdirectories as a package without removing them from the watch
list. This creates behavioral parity with Go tooling, but means a change in
testdata will still cause tests to be rerun.