Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoMsg #451

Merged
merged 3 commits into from Apr 27, 2021
Merged

SoMsg #451

merged 3 commits into from Apr 27, 2021

Conversation

kormat
Copy link
Contributor

@kormat kormat commented Oct 13, 2016

Adds a variant of So() that allows you to specify a message that is
reported on error.

Fixes #355


This change is Reviewable

@kormat
Copy link
Contributor Author

kormat commented Oct 19, 2016

Ping?

1 similar comment
@kormat
Copy link
Contributor Author

kormat commented Nov 21, 2016

Ping?

Adds a variant of So() that allows you to specify a message that is
reported on error.
@kormat
Copy link
Contributor Author

kormat commented Aug 21, 2019

We've been using this for the past 2.5+ years with no problems. I've just rebased it on master, in case there's a chance it could get merged now :)

@kormat kormat changed the title SoMsg proof of concept. SoMsg Aug 21, 2019
@riannucci
Copy link
Collaborator

Hi :)

What does this look like? I'm not sure about creating a new scope on failure (as opposed to just prepending msg to the report)

@riannucci riannucci merged commit 677d5b6 into smartystreets:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to specify comment when asserting with So()
3 participants