Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fund command to work with ledger #433

Merged
merged 1 commit into from Dec 2, 2022
Merged

Fix fund command to work with ledger #433

merged 1 commit into from Dec 2, 2022

Conversation

RodrigoAD
Copy link
Member

No description provided.

@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 11:09 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 11:09 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 11:09 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

Smoke Test Results

1 tests  ±0   0 ✔️ ±0   6m 24s ⏱️ -20s
1 suites ±0   0 💤 ±0 
1 files   ±0   1 ±0 

For more details on these failures, see this check.

Results for commit 2784399. ± Comparison against base commit 7c09106.

♻️ This comment has been updated with latest results.

@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 13:59 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 13:59 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 29, 2022 13:59 Inactive
aalu1418
aalu1418 previously approved these changes Nov 29, 2022
Copy link
Collaborator

@aalu1418 aalu1418 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! (and was tested)

archseer
archseer previously approved these changes Nov 30, 2022
@RodrigoAD RodrigoAD dismissed stale reviews from archseer and aalu1418 via 2784399 November 30, 2022 11:49
@RodrigoAD RodrigoAD temporarily deployed to integration November 30, 2022 11:49 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 30, 2022 11:49 Inactive
@RodrigoAD RodrigoAD temporarily deployed to integration November 30, 2022 11:49 Inactive
@RodrigoAD
Copy link
Member Author

@aalu1418 @archseer The CI is failing, don't know why, could you take a look?

@archseer
Copy link
Collaborator

archseer commented Dec 2, 2022

It's failing on all branches since the e2e setup got redone, feel free to ignore that

@archseer archseer merged commit d1edf3c into develop Dec 2, 2022
@archseer archseer deleted the fix-fund-command branch December 2, 2022 16:07
@aalu1418
Copy link
Collaborator

aalu1418 commented Dec 2, 2022

It's failing on all branches since the e2e setup got redone, feel free to ignore that

I think it's fixed now with #434 - but yeah the failure is ok in this case since it's unrelated code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants