Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEVEL] CCIP Receiver incompatibility with AccessControlDefaultAdminRules from OpenZeppelin #848

Closed
RyanHolanda opened this issue May 13, 2024 · 0 comments · Fixed by #926
Closed

[DEVEL] CCIP Receiver incompatibility with AccessControlDefaultAdminRules from OpenZeppelin #848

RyanHolanda opened this issue May 13, 2024 · 0 comments · Fixed by #926

Comments

@RyanHolanda
Copy link

RyanHolanda commented May 13, 2024 •
edited

Description
The CCIPReceive abstract contract is incompatible with the AccessControlDefaultAdminRules from OpenZeppelin, when implementing both, we need to override the supportsInterface(bytes4) function, but they have different state mutability, CCIPReceive uses pure, and AccessControlDefaultAdminRules uses view. So we can't override it and use super.supportsInterface(bytes4) for example

Steps to Reproduce

  1. Implement CCIP Receive (Latest Version)
  2. Implement AccessControlDefaultAdminRules (Latest Version)

Additional Information
Perhaps change the state mutability to view? because pure can override view, but the inverse is not possible
@RensR RensR mentioned this issue May 27, 2024
Merged
RensR added a commit that referenced this issue May 28, 2024
@RensR
make getRouter virtual to allow overwrites (#926)
cf82bd9 
- make getRouter virtual to allow overwrites
- Makes supportsInterface view, to resolve override issues with other
view-supportsInterface functions

Closes #848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make getRouter virtual to allow overwrites smartcontractkit/ccip
1 participant
@RyanHolanda