-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permanent identifier #54
Conversation
Your solution using |
Co-authored-by: Herman Slatman <hslatman@users.noreply.github.com>
Yes, most of the types would be string, and fail if they are not, but we can add custom types for more complex SANs, although at this moment there's no real need for it, so if we need to it will go to a different PR. |
Description
This PR adds support for the Permanent Identifier SAN (#53). With this PR, a Permanent Identifier can be added to a template data using:
It also cleans and adds more unit tests for custom SANs PR (#27), and updates
go.step.sm/crypto
CI to use Go 1.18 and Go 1.19Note that the assigner part of the Permanent Identifier is currently not supported. Suggestions are welcome. One possible solution would be to convert the
SubjectAlternativeName.Value
toany
and enforce string for most common types and support both string and a JSON for the Permanent Identifier. Other non-supported types like DirectoryNames can benefit from this. But if we want to do this, this will be part of a different PR.