Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtraNames #41

Merged
merged 5 commits into from
Mar 31, 2022
Merged

Add ExtraNames #41

merged 5 commits into from
Mar 31, 2022

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Mar 31, 2022

Description

This PR adds ExtraNames to X.509 subject and issuers, so they can be templatized. One use of this is adding the deprecated DN emailAddress.

This PR also exposes the root signer in minica and fixes linter errors with Go 1.18.

@maraino maraino requested a review from dopey March 31, 2022 01:16
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with one comment

x509util/certpool_test.go Outdated Show resolved Hide resolved
@maraino maraino merged commit 10762eb into master Mar 31, 2022
@maraino maraino deleted the feat/extraNames branch March 31, 2022 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants