You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The JavaDocs for UniRetry#atMost and MultiRetry#atMost state that "the last failure is propagated" when the number of attempts is reached. That's true, but only if no back-off has been configured. When a back-off is configured, then an IllegalStateException is thrown by ExponentialBackoff.
Doing a quick check, I saw that only UniRetry and MultiRetry actually use the randomExponentialBackoffFunction. I propose that we change it, so that it adds the IllegalStateException, with its useful message about how many retries have been made, into the list of suppressed exceptions of the original failure (Throwable#addSuppressed). WDYT?
I could take care of such a change.
The text was updated successfully, but these errors were encountered:
The JavaDocs for
UniRetry#atMost
andMultiRetry#atMost
state that "the last failure is propagated" when the number of attempts is reached. That's true, but only if no back-off has been configured. When a back-off is configured, then anIllegalStateException
is thrown byExponentialBackoff
.Doing a quick check, I saw that only
UniRetry
andMultiRetry
actually use therandomExponentialBackoffFunction
. I propose that we change it, so that it adds theIllegalStateException
, with its useful message about how many retries have been made, into the list of suppressed exceptions of the original failure (Throwable#addSuppressed
). WDYT?I could take care of such a change.
The text was updated successfully, but these errors were encountered: