Fixes #268. Added interceptor to Relocate configuration properties. #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Mar 30, 2020
implementation/src/main/java/io/smallrye/config/RelocateConfigSourceInterceptor.java
Outdated
Show resolved
Hide resolved
radcortez
force-pushed
the
#268
branch
2 times, most recently
from
50520c7
to
b9f8469
Compare
|
@dmlloyd Let me know if this is more in line with what you had in mind. I've added 2 interceptors. One for when you just want to relocate a namespace (basically giving priority to the new namespace or rule to transform the property name), and another to fallback (give priority to the original name but fallback to another name). |
dmlloyd
reviewed
Apr 10, 2020
implementation/src/main/java/io/smallrye/config/RelocateConfigSourceInterceptor.java
Show resolved
Hide resolved
|
Cleaned this up with the changes done in #275. |
dmlloyd
approved these changes
Apr 15, 2020
|
Thanks @dmlloyd :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still missing documentation. Add if we are happy with this approach.