Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antora Documentation. #267

Merged
merged 4 commits into from Mar 24, 2020
Merged

Antora Documentation. #267

merged 4 commits into from Mar 24, 2020

Conversation

radcortez
Copy link
Member

No description provided.

Copy link
Member

@jmartisk jmartisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the contents thoroughly, but from the infrastructure PoV, this looks good!

@@ -0,0 +1 @@
:version: 1.7.1-SNAPSHOT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know you can specify attributes here as well.
Ok we can either have them here, or move them to the antora.yml descriptor, depends on what you prefer.
(Bear in mind that attributes in the antora.yml descriptor require Antora 2.3.0-beta.1)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, that's how I've done it in the past working with adoc. Most likely, the antora.yml might be better. I guess you don't require to import the file on each doc where you want to use it.

@radcortez radcortez merged commit 03c8ba0 into smallrye:master Mar 24, 2020
@radcortez radcortez added this to the 1.7.1 milestone Apr 16, 2020
@radcortez radcortez linked an issue Apr 16, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document specific SmallRye Config features
2 participants