feat: Make possible to provide image as a secret #2918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil-Grigorev
requested review from
asraa,
ianlewis,
laurentsimon,
joshuagl and
kpk47
as code owners
Danil-Grigorev
changed the title
|
@Danil-Grigorev Thanks! A couple things:
|
Add option to provide image as a secret for private registries. Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
Danil-Grigorev
force-pushed
the
image-as-a-secret
branch
from
f3d1b2a
to
a9d7026
Compare
Signed-off-by: Danil Grigorev <danil.grigorev@suse.com>
|
Hi @ianlewis, I've updated changelog and workflow inputs as requested, hope it looks alright. |
ianlewis
approved these changes
Oct 27, 2023
Signed-off-by: Ian Lewis <ianlewis@google.com>
Thanks again for doing this. |
laurentsimon
added a commit
that referenced
this pull request
Nov 9, 2023
This reverts commit f5b488d.
laurentsimon
added a commit
that referenced
this pull request
Jan 16, 2024
Reverts #2918 Signed-off-by: laurentsimon <64505099+laurentsimon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to provide image as a secret for private registries.
Fixes #2917