Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] generic: GitHub Actions is temporarily unavailable #2691

Open
behnazh-w opened this issue Sep 1, 2023 · 3 comments
Open

[bug] generic: GitHub Actions is temporarily unavailable #2691

behnazh-w opened this issue Sep 1, 2023 · 3 comments
Labels
area:generic Issue with the generic generator type:bug Something isn't working
Milestone

Comments

@behnazh-w
Copy link
Contributor

behnazh-w commented Sep 1, 2023

The provenance generation on micronaut-core repository has failed after updating the provenance generator to v1.9.0 (and the error message is not helpful for debugging).

Looking into the logs, it fails at this step while creating the verifier, which seems to be a transient network issue? If that's the cause, the resilience of the generator needs to improve.

@behnazh-w behnazh-w added status:triage Issue that has not been triaged type:bug Something isn't working labels Sep 1, 2023
@laurentsimon
Copy link
Collaborator

Thanks for the issue @behnazh-w . Error is GitHub Actions is temporarily unavailable which is not under our control, afaik.

@steiza is there anything we can do? Is it something the repository uses can do (micronaut-core)?

@steiza
Copy link

steiza commented Sep 8, 2023

I'm missing some context here. I think this is the error in question?

verify: creating verifier: 503 Service Unavailable: { "message": "GitHub Actions is temporarily unavailable. Please visit https://www.githubstatus.com/ for the status of our services.", "ref": "Ref A: AFAEB017732F4791BCCA752C39D20642 Ref B: BY3EDGE0120 Ref C: 2023-08-31T17:07:15Z" }

What is verify? Is that a CLI tool that's calling GitHub APIs?

There will definitely be intermittent (and hopefully short!) cases where GitHub APIs are not available. Of course it depends on the tolerance your application has, but I think it's reasonable to retry a few times over a few minutes before giving up and reporting a failure to the end user.

@laurentsimon
Copy link
Collaborator

You're correct, the code is https://github.com/slsa-framework/slsa-github-generator/blob/main/github/oidc.go#L173-L178. Thanks for the tip, cc'ing @ianlewis for the retry

@ianlewis ianlewis added area:generic Issue with the generic generator and removed status:triage Issue that has not been triaged labels Dec 6, 2023
@laurentsimon laurentsimon added this to the Next release milestone Jan 16, 2024
@ianlewis ianlewis changed the title [bug] Provenance generation fails after updating the generator to v1.9.0 [bug] generic: GitHub Actions is temporarily unavailable May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:generic Issue with the generic generator type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants