From 18cef4fabfd34330c183fd59206748e9edada379 Mon Sep 17 00:00:00 2001 From: Evgeny Kemerov Date: Mon, 20 Sep 2021 13:17:05 +0300 Subject: [PATCH 1/4] Fix #395. Fix url for translate method --- textblob/translate.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/textblob/translate.py b/textblob/translate.py index 53b1f1ae..35b6a422 100644 --- a/textblob/translate.py +++ b/textblob/translate.py @@ -44,11 +44,13 @@ def translate(self, source, from_lang='auto', to_lang='en', host=None, type_=Non if PY2: source = source.encode('utf-8') data = {"q": source} - url = u'{url}&sl={from_lang}&tl={to_lang}&hl={to_lang}&tk={tk}'.format( + url = u'{url}&sl={from_lang}&tl={to_lang}&hl={to_lang}&tk={tk}&client={client}&format={format}'.format( url=self.url, from_lang=from_lang, to_lang=to_lang, tk=_calculate_tk(source), + client="te", + format="html", ) response = self._request(url, host=host, type_=type_, data=data) result = json.loads(response) From 1b340fb12d542a6c7cacc228134fd298e3eaf30d Mon Sep 17 00:00:00 2001 From: Evgeny Kemerov Date: Mon, 20 Sep 2021 13:40:05 +0300 Subject: [PATCH 2/4] Update AUTHORS.rst --- AUTHORS.rst | 1 + 1 file changed, 1 insertion(+) diff --git a/AUTHORS.rst b/AUTHORS.rst index 4328bcb7..a00d4c6e 100644 --- a/AUTHORS.rst +++ b/AUTHORS.rst @@ -32,3 +32,4 @@ Contributors (chronological) - Roman Korolev `@roman-y-korolev `_ - Ram Rachum `@cool-RR `_ - Romain Casati `@casatir `_ +- Evgeny Kemerov `@sudoguy `_ From e2b24d57532a865fda151c15b7d2963f576f5692 Mon Sep 17 00:00:00 2001 From: Evgeny Kemerov Date: Sun, 3 Oct 2021 19:36:09 +0300 Subject: [PATCH 3/4] Remove html format and fix detect method --- textblob/translate.py | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/textblob/translate.py b/textblob/translate.py index 35b6a422..f01ce963 100644 --- a/textblob/translate.py +++ b/textblob/translate.py @@ -44,13 +44,12 @@ def translate(self, source, from_lang='auto', to_lang='en', host=None, type_=Non if PY2: source = source.encode('utf-8') data = {"q": source} - url = u'{url}&sl={from_lang}&tl={to_lang}&hl={to_lang}&tk={tk}&client={client}&format={format}'.format( + url = u'{url}&sl={from_lang}&tl={to_lang}&hl={to_lang}&tk={tk}&client={client}'.format( url=self.url, from_lang=from_lang, to_lang=to_lang, tk=_calculate_tk(source), client="te", - format="html", ) response = self._request(url, host=host, type_=type_, data=data) result = json.loads(response) @@ -69,7 +68,11 @@ def detect(self, source, host=None, type_=None): if len(source) < 3: raise TranslatorError('Must provide a string with at least 3 characters.') data = {"q": source} - url = u'{url}&sl=auto&tk={tk}'.format(url=self.url, tk=_calculate_tk(source)) + url = u'{url}&sl=auto&tk={tk}&client={client}'.format( + url=self.url, + tk=_calculate_tk(source), + client="te", + ) response = self._request(url, host=host, type_=type_, data=data) result, language = json.loads(response) return language From d243e6bca980f8de471906582ba0a9a10f1baf80 Mon Sep 17 00:00:00 2001 From: Steven Loria Date: Thu, 21 Oct 2021 23:09:09 -0400 Subject: [PATCH 4/4] Update changelog --- CHANGELOG.rst | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/CHANGELOG.rst b/CHANGELOG.rst index f990401e..8c0512cf 100644 --- a/CHANGELOG.rst +++ b/CHANGELOG.rst @@ -1,6 +1,14 @@ Changelog ========= +0.17.1 (unreleased) +------------------- + +Bug fixes: + +- Fix translation and language detection (:issue:`395`). + Thanks :user:`sudoguy` for the patch. + 0.17.0 (2021-02-17) -------------------