Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect return type hints on NotFound handler #2609

Merged
merged 1 commit into from Mar 12, 2019
Merged

Fix incorrect return type hints on NotFound handler #2609

merged 1 commit into from Mar 12, 2019

Conversation

rbairwell
Copy link

Type hints were incorrect on the NotFound handler. Methods were returning strings when the type hint said ResponseInterface: the calling method is expecting strings.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.832% when pulling 2cf98e9 on rbairwell:patch-1 into 04e7689 on slimphp:3.x.

@l0gicgate l0gicgate added this to the 3.13.0 milestone Mar 12, 2019
@l0gicgate l0gicgate merged commit 7b9967f into slimphp:3.x Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants