Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put HeaderStackTestAsset into Slim\Tests\Asset namespace #2520

Merged
merged 1 commit into from Nov 27, 2018
Merged

Put HeaderStackTestAsset into Slim\Tests\Asset namespace #2520

merged 1 commit into from Nov 27, 2018

Conversation

akrabat
Copy link
Member

@akrabat akrabat commented Oct 16, 2018

This allows us to minimise what we put into the Slim namespace to just
the header() and headers_sent() functions.

We also rename HeaderStackTestAsset to HeaderStack as the namespace is
descriptive.

This allows us to minimise what we put into the Slim namespace to just
the header() and headers_sent() functions.

We also rename HeaderStackTestAsset to HeaderStack as the namespace is
descriptive.
@akrabat akrabat added the Slim 3 label Oct 16, 2018
@akrabat akrabat added this to the 3.12 milestone Oct 16, 2018
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.814% when pulling 874bbcb on akrabat:tidy-up-header-test-assets into 6d34747 on slimphp:3.x.

@l0gicgate
Copy link
Member

Reviewed, looks good to me!

@akrabat akrabat merged commit 874bbcb into slimphp:3.x Nov 27, 2018
akrabat added a commit that referenced this pull request Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants