Add PHPStan (config) and some fixes #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tersmitten
commented
Sep 20, 2018
| parameters: | ||
| ignoreErrors: | ||
| # - '#Parameter \$to of method Slim\\App::redirect\(\) has invalid typehint type Slim\\UriInterface#' | ||
| # - '#Variable \$_FILES in isset\(\) always exists and is not nullable#' |
There was a problem hiding this comment.
Some example config, to show how to ignore certain (found) errors
tersmitten
commented
Sep 20, 2018
| - if [[ "$TRAVIS_PHP_VERSION" != '5.6' ]]; then composer install -n ; fi | ||
|
|
||
| script: | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '5.6' ]]; then vendor/bin/phpunit --coverage-clover clover.xml ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" != '5.6' ]]; then vendor/bin/phpunit ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '5.6' ]]; then vendor/bin/phpcs ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '7.1' ]]; then vendor/bin/phpstan analyse Slim -l 1 || true ; fi |
tersmitten
commented
Sep 20, 2018
| - if [[ "$TRAVIS_PHP_VERSION" != '5.6' ]]; then composer install -n ; fi | ||
|
|
||
| script: | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '5.6' ]]; then vendor/bin/phpunit --coverage-clover clover.xml ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" != '5.6' ]]; then vendor/bin/phpunit ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '5.6' ]]; then vendor/bin/phpcs ; fi | ||
| - if [[ "$TRAVIS_PHP_VERSION" == '7.1' ]]; then vendor/bin/phpstan analyse Slim -l 1 || true ; fi |
There was a problem hiding this comment.
It's only at level 1 now, this can be increased over the time
This was referenced Oct 17, 2018
akrabat
added a commit
that referenced
this pull request
Nov 25, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.