Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify CallableResolver and AdvancedCallableResolver #3073

Open
l0gicgate opened this issue Apr 25, 2021 · 2 comments
Open

Unify CallableResolver and AdvancedCallableResolver #3073

l0gicgate opened this issue Apr 25, 2021 · 2 comments
Labels

Comments

@l0gicgate
Copy link
Member

Since AdvancedCallableResolver was introduced midway through the release of Slim 4, we will need to unify the two interfaces in Slim 5 and break everything moving forward.

We will also need to ensure that the CallableResolverInterface::resolve() method throws a named exception instead of RuntimeException so downstream implementers can effectively control the execution flow.

@ddrv
Copy link
Contributor

ddrv commented Nov 19, 2021

@l0gicgate make 5.x branch please so that interested contributors can send pull requests

@l0gicgate
Copy link
Member Author

@ddrv I do not have the bandwidth to maintain 3 branches. The Slim 4 docs are still in somewhat abysmal shape. Creating a Slim 5 branch right now would be a ton of extra work with very little upside. I appreciate the eagerness to get this going but I don't think the timing is adequate right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants