Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No development branch #2843

Closed
piotr-cz opened this issue Sep 24, 2019 · 4 comments · Fixed by #2846
Closed

No development branch #2843

piotr-cz opened this issue Sep 24, 2019 · 4 comments · Fixed by #2846
Labels
easy pick Slim 3 Slim 4

Comments

@piotr-cz
Copy link
Contributor

CONTRIBUTING.md says new pull requests should be created against develop branch, but ATM there is no branch witch such name.
@l0gicgate
Copy link
Member

We should probably change that to 4.x

@piotr-cz
Copy link
Contributor Author

Both 4.x and 3.x branches have own CONTRIBUTING.md files so there may be updated separately

@l0gicgate
Copy link
Member

Yes @piotr-cz

@pmvieira pmvieira mentioned this issue Sep 25, 2019
Merged
@piotr-cz
Copy link
Contributor Author

piotr-cz commented Sep 30, 2019 •
edited

Resolved via #2846,
there is no need to update CONTRIBUTING.md file for 3.x branch as it says

Send a pull request from each feature branch against the version branch for which your fix is intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
easy pick Slim 3 Slim 4
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correcting the branch name as per issue-2843 pmvieira/Slim
2 participants
@piotr-cz @l0gicgate