From a7c9da8f10da065d3d5faa027bdc7d9cca8e92ad Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Tue, 19 Feb 2019 17:38:00 -0700 Subject: [PATCH 01/17] add improved cache file writability detection in Router --- Slim/Router.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index fda948943..3363158d7 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -130,16 +130,19 @@ public function getBasePath() */ public function setCacheFile($cacheFile) { + $this->cacheFile = $cacheFile; + if (!is_string($cacheFile) && $cacheFile !== false) { - throw new InvalidArgumentException('Router cacheFile must be a string or false'); + throw new InvalidArgumentException('Router cache file must be a string or false'); } - $this->cacheFile = $cacheFile; - - if ($cacheFile !== false && !is_writable(dirname($cacheFile))) { - throw new RuntimeException('Router cacheFile directory must be writable'); + if ($cacheFile && file_exists($cacheFile) && !is_writable($cacheFile)) { + throw new RuntimeException(sprintf('Router cache file `%s` is not writable', $cacheFile)); } + if ($cacheFile && !file_exists($cacheFile) && !is_writable(dirname($cacheFile))) { + throw new RuntimeException(sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile))); + } return $this; } From 349109a743076d9bc30ef8ecf3967e1cee14855f Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Tue, 19 Feb 2019 17:38:11 -0700 Subject: [PATCH 02/17] add supporting tests --- tests/RouterTest.php | 27 +++++++++++++++++++++------ 1 file changed, 21 insertions(+), 6 deletions(-) diff --git a/tests/RouterTest.php b/tests/RouterTest.php index e340dcb88..4e0360539 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -333,24 +333,39 @@ public function testSettingInvalidCacheFileValue() { $this->setExpectedException( '\InvalidArgumentException', - 'Router cacheFile must be a string' + 'Router cache file must be a string' ); $this->router->setCacheFile(['invalid']); } /** - * Test if cacheFile is not a writable directory + * Test cache file exists but is not writable */ - public function testSettingInvalidCacheFileNotExisting() + public function testCacheFileExistsAndIsNotWritable() { + $cacheFile = __DIR__ . '/RouterCache/NonWritableCache.php'; + $this->setExpectedException( '\RuntimeException', - 'Router cacheFile directory must be writable' + sprintf('Router cache file `%s` is not writable', $cacheFile) ); - $this->router->setCacheFile( - dirname(__FILE__) . uniqid(microtime(true)) . '/' . uniqid(microtime(true)) + $this->router->setCacheFile($cacheFile); + } + + /** + * Test cache file does not exist and directory is not writable + */ + public function testCacheFileDoesNotExistsAndDirectoryIsNotWritable() + { + $cacheFile = __DIR__ . '/RouterCache/NonWritableDirectory/WritableFile.php'; + + $this->setExpectedException( + '\RuntimeException', + sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) ); + + $this->router->setCacheFile($cacheFile); } /** From cda57b8f1d02542f5866306cdc523bce37e1b7b2 Mon Sep 17 00:00:00 2001 From: Date: Tue, 19 Feb 2019 17:46:01 -0700 Subject: [PATCH 03/17] add mock router cache file and directory --- tests/RouterCache/NonWritableCache.php | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/RouterCache/NonWritableCache.php diff --git a/tests/RouterCache/NonWritableCache.php b/tests/RouterCache/NonWritableCache.php new file mode 100644 index 000000000..e69de29bb From 34aa7d787dae4b4bb09e309d5cdda4a813345c66 Mon Sep 17 00:00:00 2001 From: Date: Tue, 19 Feb 2019 17:48:01 -0700 Subject: [PATCH 04/17] add writable cache file --- tests/RouterCache/NonWritableDirectory/WritableCache.php | 0 1 file changed, 0 insertions(+), 0 deletions(-) create mode 100644 tests/RouterCache/NonWritableDirectory/WritableCache.php diff --git a/tests/RouterCache/NonWritableDirectory/WritableCache.php b/tests/RouterCache/NonWritableDirectory/WritableCache.php new file mode 100644 index 000000000..e69de29bb From 6a350316f487b13579544adab4a93f047ef79ce1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 21:46:59 -0700 Subject: [PATCH 05/17] remove RouterCache directory from tests folder --- tests/RouterCache/NonWritableCache.php | 0 tests/RouterCache/NonWritableDirectory/WritableCache.php | 0 2 files changed, 0 insertions(+), 0 deletions(-) delete mode 100644 tests/RouterCache/NonWritableCache.php delete mode 100644 tests/RouterCache/NonWritableDirectory/WritableCache.php diff --git a/tests/RouterCache/NonWritableCache.php b/tests/RouterCache/NonWritableCache.php deleted file mode 100644 index e69de29bb..000000000 diff --git a/tests/RouterCache/NonWritableDirectory/WritableCache.php b/tests/RouterCache/NonWritableDirectory/WritableCache.php deleted file mode 100644 index e69de29bb..000000000 From ea2c6f1f8c0146f3c9596e122200cd72a29c31b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 21:47:51 -0700 Subject: [PATCH 06/17] refactor Router to use isCacheFileWritable() --- Slim/Router.php | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 3363158d7..2c17d5f3a 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -136,17 +136,28 @@ public function setCacheFile($cacheFile) throw new InvalidArgumentException('Router cache file must be a string or false'); } - if ($cacheFile && file_exists($cacheFile) && !is_writable($cacheFile)) { + if ($cacheFile && file_exists($cacheFile) && !$this->isCacheFileWritable($cacheFile)) { throw new RuntimeException(sprintf('Router cache file `%s` is not writable', $cacheFile)); } - if ($cacheFile && !file_exists($cacheFile) && !is_writable(dirname($cacheFile))) { + if ($cacheFile && !file_exists($cacheFile) && !$this->isCacheFileWritable(dirname($cacheFile))) { throw new RuntimeException(sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile))); } return $this; } + /** + * This method is in place to facilitate unit tests + * @param $cacheFile + * + * @return bool + */ + protected function isCacheFileWritable($cacheFile) + { + return is_writable($cacheFile); + } + /** * @param ContainerInterface $container */ From 0d7b020d3483eda79edd05e871e00adee1c726d0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 21:48:37 -0700 Subject: [PATCH 07/17] refactor tests to use isCacheFileWritable() stub --- tests/RouterTest.php | 45 ++++++++++++++++++++++++++++++++++++++------ 1 file changed, 39 insertions(+), 6 deletions(-) diff --git a/tests/RouterTest.php b/tests/RouterTest.php index 4e0360539..221b66913 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -6,9 +6,9 @@ * @copyright Copyright (c) 2011-2017 Josh Lockhart * @license https://github.com/slimphp/Slim/blob/3.x/LICENSE.md (MIT License) */ + namespace Slim\Tests; -use Slim\Container; use Slim\Router; class RouterTest extends \PHPUnit_Framework_TestCase @@ -16,11 +16,21 @@ class RouterTest extends \PHPUnit_Framework_TestCase /** @var Router */ protected $router; + /** @var string */ + protected $cacheFile; + public function setUp() { $this->router = new Router; } + public function tearDown() + { + if (file_exists($this->cacheFile)) { + unlink($this->cacheFile); + } + } + public function testMap() { $methods = ['GET']; @@ -343,14 +353,26 @@ public function testSettingInvalidCacheFileValue() */ public function testCacheFileExistsAndIsNotWritable() { - $cacheFile = __DIR__ . '/RouterCache/NonWritableCache.php'; + $this->cacheFile = __DIR__ . '/' . time() . '.cache'; + file_put_contents($this->cacheFile, ''); $this->setExpectedException( '\RuntimeException', - sprintf('Router cache file `%s` is not writable', $cacheFile) + sprintf('Router cache file `%s` is not writable', $this->cacheFile) ); - $this->router->setCacheFile($cacheFile); + $mock = $this + ->getMockBuilder(Router::class) + ->disableOriginalConstructor() + ->setMethods(['isCacheFileWritable']) + ->getMock(); + + $mock->expects($this->any()) + ->method('isCacheFileWritable') + ->will($this->returnValue(false)); + + /** @var Router $mock */ + $mock->setCacheFile($this->cacheFile); } /** @@ -358,14 +380,25 @@ public function testCacheFileExistsAndIsNotWritable() */ public function testCacheFileDoesNotExistsAndDirectoryIsNotWritable() { - $cacheFile = __DIR__ . '/RouterCache/NonWritableDirectory/WritableFile.php'; + $cacheFile = __DIR__ . '/NonWritableDirectory/WritableFile.php'; $this->setExpectedException( '\RuntimeException', sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) ); - $this->router->setCacheFile($cacheFile); + $mock = $this + ->getMockBuilder(Router::class) + ->disableOriginalConstructor() + ->setMethods(['isCacheFileWritable']) + ->getMock(); + + $mock->expects($this->any()) + ->method('isCacheFileWritable') + ->will($this->returnValue(false)); + + /** @var Router $mock */ + $mock->setCacheFile($cacheFile); } /** From 5938faf02805234b7426ee73d891511bd348f8fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 21:54:09 -0700 Subject: [PATCH 08/17] fix code style error --- tests/RouterTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/RouterTest.php b/tests/RouterTest.php index 221b66913..ff25711a2 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -372,7 +372,7 @@ public function testCacheFileExistsAndIsNotWritable() ->will($this->returnValue(false)); /** @var Router $mock */ - $mock->setCacheFile($this->cacheFile); + $mock->setCacheFile($this->cacheFile); } /** From ec0ae2012f8e2f71114e35d24712960250570dad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 21:59:33 -0700 Subject: [PATCH 09/17] fix code style error in Router --- Slim/Router.php | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 2c17d5f3a..3f0fefe9e 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -137,11 +137,15 @@ public function setCacheFile($cacheFile) } if ($cacheFile && file_exists($cacheFile) && !$this->isCacheFileWritable($cacheFile)) { - throw new RuntimeException(sprintf('Router cache file `%s` is not writable', $cacheFile)); + throw new RuntimeException( + sprintf('Router cache file `%s` is not writable', $cacheFile) + ); } if ($cacheFile && !file_exists($cacheFile) && !$this->isCacheFileWritable(dirname($cacheFile))) { - throw new RuntimeException(sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile))); + throw new RuntimeException( + sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) + ); } return $this; From 762f45226f2d061d37be435463e906b1cba8f62b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 22:56:47 -0700 Subject: [PATCH 10/17] fix logic based on further examination of FastRoute cachedDispatcher --- Slim/Router.php | 21 +++++++++++++++++---- tests/RouterTest.php | 12 ++++++------ 2 files changed, 23 insertions(+), 10 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 3f0fefe9e..55e8bcc72 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -136,13 +136,13 @@ public function setCacheFile($cacheFile) throw new InvalidArgumentException('Router cache file must be a string or false'); } - if ($cacheFile && file_exists($cacheFile) && !$this->isCacheFileWritable($cacheFile)) { + if ($cacheFile && file_exists($cacheFile) && !$this->isCacheFileReadable($cacheFile)) { throw new RuntimeException( - sprintf('Router cache file `%s` is not writable', $cacheFile) + sprintf('Router cache file `%s` is not readable', $cacheFile) ); } - if ($cacheFile && !file_exists($cacheFile) && !$this->isCacheFileWritable(dirname($cacheFile))) { + if ($cacheFile && !file_exists($cacheFile) && !$this->isCacheDirWritable(dirname($cacheFile))) { throw new RuntimeException( sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) ); @@ -153,11 +153,24 @@ public function setCacheFile($cacheFile) /** * This method is in place to facilitate unit tests + * + * @param $cacheFile + * + * @return bool + */ + protected function isCacheFileReadable($cacheFile) + { + return is_readable($cacheFile); + } + + /** + * This method is in place to facilitate unit tests + * * @param $cacheFile * * @return bool */ - protected function isCacheFileWritable($cacheFile) + protected function isCacheDirWritable($cacheFile) { return is_writable($cacheFile); } diff --git a/tests/RouterTest.php b/tests/RouterTest.php index ff25711a2..6b52615c9 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -351,24 +351,24 @@ public function testSettingInvalidCacheFileValue() /** * Test cache file exists but is not writable */ - public function testCacheFileExistsAndIsNotWritable() + public function testCacheFileExistsAndIsNotReadable() { $this->cacheFile = __DIR__ . '/' . time() . '.cache'; file_put_contents($this->cacheFile, ''); $this->setExpectedException( '\RuntimeException', - sprintf('Router cache file `%s` is not writable', $this->cacheFile) + sprintf('Router cache file `%s` is not readable', $this->cacheFile) ); $mock = $this ->getMockBuilder(Router::class) ->disableOriginalConstructor() - ->setMethods(['isCacheFileWritable']) + ->setMethods(['isCacheFileReadable']) ->getMock(); $mock->expects($this->any()) - ->method('isCacheFileWritable') + ->method('isCacheFileReadable') ->will($this->returnValue(false)); /** @var Router $mock */ @@ -390,11 +390,11 @@ public function testCacheFileDoesNotExistsAndDirectoryIsNotWritable() $mock = $this ->getMockBuilder(Router::class) ->disableOriginalConstructor() - ->setMethods(['isCacheFileWritable']) + ->setMethods(['isCacheDirWritable']) ->getMock(); $mock->expects($this->any()) - ->method('isCacheFileWritable') + ->method('isCacheDirWritable') ->will($this->returnValue(false)); /** @var Router $mock */ From 40b6facbe63d4286f14c8acaaf99e56fe6ab3452 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Pierre=20B=C3=A9rub=C3=A9?= Date: Tue, 19 Feb 2019 23:03:18 -0700 Subject: [PATCH 11/17] rename $cacheFile to $cacheDir for isCacheDirWritable() method --- Slim/Router.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 55e8bcc72..7c18ce381 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -166,13 +166,13 @@ protected function isCacheFileReadable($cacheFile) /** * This method is in place to facilitate unit tests * - * @param $cacheFile + * @param $cacheDir * * @return bool */ - protected function isCacheDirWritable($cacheFile) + protected function isCacheDirWritable($cacheDir) { - return is_writable($cacheFile); + return is_writable($cacheDir); } /** From 33e94ed8486661a1647e4cf493fe0f1abae94c9c Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Wed, 20 Feb 2019 15:17:08 -0700 Subject: [PATCH 12/17] remove Router::isCacheFileReadable() and Router::isCacheDirWritable() --- Slim/Router.php | 28 ++-------------------------- 1 file changed, 2 insertions(+), 26 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 7c18ce381..9ddb99da9 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -136,13 +136,13 @@ public function setCacheFile($cacheFile) throw new InvalidArgumentException('Router cache file must be a string or false'); } - if ($cacheFile && file_exists($cacheFile) && !$this->isCacheFileReadable($cacheFile)) { + if ($cacheFile && file_exists($cacheFile) && !is_readable($cacheFile)) { throw new RuntimeException( sprintf('Router cache file `%s` is not readable', $cacheFile) ); } - if ($cacheFile && !file_exists($cacheFile) && !$this->isCacheDirWritable(dirname($cacheFile))) { + if ($cacheFile && !file_exists($cacheFile) && !is_writable(dirname($cacheFile))) { throw new RuntimeException( sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) ); @@ -151,30 +151,6 @@ public function setCacheFile($cacheFile) return $this; } - /** - * This method is in place to facilitate unit tests - * - * @param $cacheFile - * - * @return bool - */ - protected function isCacheFileReadable($cacheFile) - { - return is_readable($cacheFile); - } - - /** - * This method is in place to facilitate unit tests - * - * @param $cacheDir - * - * @return bool - */ - protected function isCacheDirWritable($cacheDir) - { - return is_writable($cacheDir); - } - /** * @param ContainerInterface $container */ From 645418ead137f09a0319ca51ef38440f46092633 Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Wed, 20 Feb 2019 15:17:48 -0700 Subject: [PATCH 13/17] modify tests for changes to Router --- tests/Assets/HeaderFunctions.php | 28 ++++++++++++++++++++++++++++ tests/RouterTest.php | 30 ++++-------------------------- 2 files changed, 32 insertions(+), 26 deletions(-) diff --git a/tests/Assets/HeaderFunctions.php b/tests/Assets/HeaderFunctions.php index e7327d042..53346d520 100644 --- a/tests/Assets/HeaderFunctions.php +++ b/tests/Assets/HeaderFunctions.php @@ -57,3 +57,31 @@ function header($string, $replace = true, $statusCode = null) ] ); } + +/** + * Is a file descriptor writable + * + * @param $file + * @return bool + */ +function is_readable($file) +{ + if (stripos($file, 'non-readable.cache') !== false) { + return false; + } + return true; +} + +/** + * Is a path writable + * + * @param $path + * @return bool + */ +function is_writable($path) +{ + if (stripos($path, 'non-writable-directory') !== false) { + return false; + } + return true; +} \ No newline at end of file diff --git a/tests/RouterTest.php b/tests/RouterTest.php index 6b52615c9..c524af04f 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -353,7 +353,7 @@ public function testSettingInvalidCacheFileValue() */ public function testCacheFileExistsAndIsNotReadable() { - $this->cacheFile = __DIR__ . '/' . time() . '.cache'; + $this->cacheFile = __DIR__ . '/non-readable.cache'; file_put_contents($this->cacheFile, ''); $this->setExpectedException( @@ -361,18 +361,7 @@ public function testCacheFileExistsAndIsNotReadable() sprintf('Router cache file `%s` is not readable', $this->cacheFile) ); - $mock = $this - ->getMockBuilder(Router::class) - ->disableOriginalConstructor() - ->setMethods(['isCacheFileReadable']) - ->getMock(); - - $mock->expects($this->any()) - ->method('isCacheFileReadable') - ->will($this->returnValue(false)); - - /** @var Router $mock */ - $mock->setCacheFile($this->cacheFile); + $this->router->setCacheFile($this->cacheFile); } /** @@ -380,25 +369,14 @@ public function testCacheFileExistsAndIsNotReadable() */ public function testCacheFileDoesNotExistsAndDirectoryIsNotWritable() { - $cacheFile = __DIR__ . '/NonWritableDirectory/WritableFile.php'; + $cacheFile = __DIR__ . '/non-writable-directory/router.cache'; $this->setExpectedException( '\RuntimeException', sprintf('Router cache file directory `%s` is not writable', dirname($cacheFile)) ); - $mock = $this - ->getMockBuilder(Router::class) - ->disableOriginalConstructor() - ->setMethods(['isCacheDirWritable']) - ->getMock(); - - $mock->expects($this->any()) - ->method('isCacheDirWritable') - ->will($this->returnValue(false)); - - /** @var Router $mock */ - $mock->setCacheFile($cacheFile); + $this->router->setCacheFile($cacheFile); } /** From d4dcb79d7b0cee45c504f0203673de22555d8360 Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Wed, 20 Feb 2019 15:21:37 -0700 Subject: [PATCH 14/17] fix code style error --- tests/Assets/HeaderFunctions.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Assets/HeaderFunctions.php b/tests/Assets/HeaderFunctions.php index 53346d520..3458e5433 100644 --- a/tests/Assets/HeaderFunctions.php +++ b/tests/Assets/HeaderFunctions.php @@ -84,4 +84,4 @@ function is_writable($path) return false; } return true; -} \ No newline at end of file +} From c86ac97989c79de08e353268bcc1968a2e3df7fc Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Wed, 20 Feb 2019 15:31:02 -0700 Subject: [PATCH 15/17] fix code style errors --- tests/RouterTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/RouterTest.php b/tests/RouterTest.php index c524af04f..d5fbc2984 100644 --- a/tests/RouterTest.php +++ b/tests/RouterTest.php @@ -361,7 +361,7 @@ public function testCacheFileExistsAndIsNotReadable() sprintf('Router cache file `%s` is not readable', $this->cacheFile) ); - $this->router->setCacheFile($this->cacheFile); + $this->router->setCacheFile($this->cacheFile); } /** From 7bf88231fa02c2be6aba5215987ca59497a1570b Mon Sep 17 00:00:00 2001 From: l0gicgate Date: Thu, 21 Feb 2019 12:58:58 -0700 Subject: [PATCH 16/17] change variable assignment for $cacheFile in Router --- Slim/Router.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/Slim/Router.php b/Slim/Router.php index 9ddb99da9..d3ac825b5 100644 --- a/Slim/Router.php +++ b/Slim/Router.php @@ -130,8 +130,6 @@ public function getBasePath() */ public function setCacheFile($cacheFile) { - $this->cacheFile = $cacheFile; - if (!is_string($cacheFile) && $cacheFile !== false) { throw new InvalidArgumentException('Router cache file must be a string or false'); } @@ -148,6 +146,7 @@ public function setCacheFile($cacheFile) ); } + $this->cacheFile = $cacheFile; return $this; } From b4e7bbf50413bc94ae1bc36c8de9f89e7f1f8012 Mon Sep 17 00:00:00 2001 From: Rob Allen Date: Fri, 22 Feb 2019 07:41:43 +0000 Subject: [PATCH 17/17] Rename HeaderFunctions.php to PhpFunctionOverrides.php --- composer.json | 2 +- tests/Assets/{HeaderFunctions.php => PhpFunctionOverrides.php} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tests/Assets/{HeaderFunctions.php => PhpFunctionOverrides.php} (100%) diff --git a/composer.json b/composer.json index db3a11a97..ca85d580d 100644 --- a/composer.json +++ b/composer.json @@ -49,7 +49,7 @@ }, "autoload-dev": { "files": [ - "tests/Assets/HeaderFunctions.php" + "tests/Assets/PhpFunctionOverrides.php" ] }, "scripts": { diff --git a/tests/Assets/HeaderFunctions.php b/tests/Assets/PhpFunctionOverrides.php similarity index 100% rename from tests/Assets/HeaderFunctions.php rename to tests/Assets/PhpFunctionOverrides.php