Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop PHP 7.2 #204

Merged
merged 2 commits into from
Sep 22, 2021
Merged

Drop PHP 7.2 #204

merged 2 commits into from
Sep 22, 2021

Conversation

t0mmy742
Copy link
Contributor

As we already did on main Slim repo, we drop here PHP 7.2
Waiting last PR about resolving one test to be merged before merging this one.

@l0gicgate l0gicgate added this to the 1.5 milestone Sep 22, 2021
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.621% when pulling 1cb08c3 on t0mmy742:feature/drop_php7.2 into 323ea3b on slimphp:master.

@l0gicgate l0gicgate marked this pull request as ready for review September 22, 2021 04:32
@l0gicgate l0gicgate merged commit a47b43a into slimphp:master Sep 22, 2021
@t0mmy742 t0mmy742 deleted the feature/drop_php7.2 branch September 22, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0gicgate l0gicgate l0gicgate approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t0mmy742 @coveralls @l0gicgate