Fix build for Rails #844
Merged
Fix build for Rails #844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stonean not sure why the build didn't show up in GH's interface. The build passed: https://travis-ci.org/github/slim-template/slim/builds/665194012 |
Looking at the build pipeline, the build stopped failing without any changes to the code that would indicate a problem. The only thing that I could discern was that a dependency must have gotten an update causing the failure. After doing some digging, I saw that `Sprockets` had gotten a major release to `4.0.0`. The configuration in `test/rails/config/application.rb`, the source of the build failure, checks to see if the `Sprockets` version is > 3. If so, it triggers some code that was also used in [`slim-rails`](https://github.com/slim-template/slim-rails/blob/b19741ba76a09a3badd0c5145dea6b087064fb87/lib/slim-rails/register_engine.rb#L31-L39), per [this commit from a couple years ago](slim-template@14a845a). The code works fine in `slim-rails` because `RegisterEngine` [lives in `slim-rails`](https://github.com/slim-template/slim-rails/blob/b19741ba76a09a3badd0c5145dea6b087064fb87/lib/slim-rails/register_engine.rb#L1), but unfortunately does not exist in the core `slim` project, causing the `NameError`. I suppose this was missed because until recently `Sprockets` was < 4.0 and the code written a couple years back never needed to run. To fix this, I added the `slim-rails` gem to the `Gemfile`, and included the missing `RegisterEngine` module.
|
Thanks for the merge, @stonean ! |
|
thank you for the contribution! @thewatts ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at the build pipeline, the build stopped failing without any changes to the code that would indicate a problem.
The only thing that I could discern was that a dependency must have gotten an update causing the failure.
After doing some digging, I saw that
Sprocketshad gotten a major release to4.0.0.The configuration in
test/rails/config/application.rb, the source of the build failure, checks to see if theSprocketsversion is > 3.If so, it triggers some code that was also used in
slim-rails, per this commit from a couple years ago.The code works fine in
slim-railsbecauseRegisterEnginelives inslim-rails, but unfortunately does not exist in the coreslimproject, causing theNameError.I suppose this was missed because until recently
Sprocketswas < 4.0 and the code written a couple years back never needed to run.To fix this, I added the
slim-railsgem to theGemfile, and included the missingRegisterEnginemodule.Note: Recreating PR to trigger Travis' build process. They were under maintenance last night. All of the individual build scenarios passed, but it failed overall due to maintenance.
The old PR is here #843