HTML5 custom hyphenated attribute

[cuihq]

Issues:

slim code:

div data={object_id: 1}

html expect:

<div data-object_id="1"></div>

html actual:

<div data-object-id="1"></div>

Reason:

The custom attributes are all underscore.
Do not need to switch between underscore and dasherize (camelize).
So compatibility is better.

• compatible with ruby

{object_id: 1} # not {'object-id' => 1} or {objectId: 1}

• compatible with javascript/coffeescript

element.dataset.object_id // not element.dataset.objectId

• compatible whit jQuery

$(element).data('object_id') // not $(element).data('objectId')

Validate:

validate attribute data-object_id:

• https://html5.validator.nu/
• https://validator.w3.org/nu/#textarea

Code:

slim/lib/slim/splat/builder.rb

Line 94 in 5cc796c

hyphen_attr("#{name}-#{n.to_s.gsub('_', '-')}", escape, v)

modified code:

hyphen_attr("#{name}-#{n}", escape, v)

Test:

Test code that needs to be changed:

slim/test/core/test_html_attributes.rb

Line 111 in 5cc796c

def test_hyphenated_attribute

[atiqueakhtar]

Hi @cuihq @stonean In my app I found out that the changes are working as expected for simple HTML tags where we use data attributes like this - data = {first_name: 'Stephen'} and not data: {first_name: 'Stephen'} but in form helpers like simple_form_for where we use them strictly as data: { disable_with: 'One Moment' }, the expected change of data-disable_with="One Moment" is not observed.