Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer needs to be visible if the content height less than the screen height #78

Open
miyurugunarathna opened this issue Jul 16, 2023 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@miyurugunarathna
Copy link
Member

Screenshot 2023-07-16 at 11 13 22 PM
@miyurugunarathna miyurugunarathna added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 16, 2023
@PratikMbade
Copy link

@miyurugunarathna can you add more screenshots or video so i can understand your issue.

@miyurugunarathna
Copy link
Member Author

Screen.Recording.2023-07-16.at.11.35.24.PM.mov

@PratikMbade as you can see in the video footer is out of the initial screen where there are more space. The requirement is footer and the content should have 100px gap. it can only grow when all content height including footer less that the screen height.

@PratikMbade
Copy link

PratikMbade commented Jul 16, 2023

@miyurugunarathna thank you for explanation, I've understood this issue. I will work on it, assign me this issue

@PratikMbade
Copy link

@miyurugunarathna I've just checked the issue, in my browser, It looks ok, you can please see your web browser zoom size its 67% may be, and that's why it looks different to you, you can just reset your browser size to 100%.

@miyurugunarathna
Copy link
Member Author

@PratikMbade it's not the zoom size. if you inspect the element you can see

element's min height set to screen height, in that case if the content smaller that the screen height it will create extra height because it will push header and the footer to outside. Hope you got the point. if not ping me I'll explain further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants