Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support extensions property #19

Closed
MichalLytek opened this issue Sep 21, 2019 · 3 comments
Closed

Support extensions property #19

MichalLytek opened this issue Sep 21, 2019 · 3 comments

Comments

@MichalLytek
Copy link
Contributor

As graphql-js now has a dedicated mechanism for storing additional metadata, we should use that to place and read complexity info from constructed types:
graphql/graphql-js#2097
ivome added a commit that referenced this issue Sep 23, 2019
@ivome
Add fieldExtensionsEstimator, deprecate fieldConfigEstimator #19
0ef07a4
@ivome ivome mentioned this issue Sep 23, 2019
Merged
@ivome
Copy link
Collaborator

ivome commented Sep 23, 2019

This is great news... thanks for raising the issue! I added a new fieldExtensionsEstimator and added deprecation notices to the fieldConfigEstimator so we can remove this in future releases (plus those hacky TypeScript extensions of the GraphQL types we currently have).

@MichalLytek
Copy link
Contributor Author

MichalLytek commented Sep 23, 2019 •
edited

those hacky TypeScript extensions of the GraphQL types we currently have

They are not so bad, it's better to provide typings for the properties because this will check the signature of function which results in better DX. However I haven't tried to merge declarations for extenstions as they might be typed as record with any 😕

ivome added a commit that referenced this issue Oct 6, 2019
@ivome
Merge pull request #20 from slicknode/feature/field-extension-estimator
61f5803 
Field extension estimator #19
@ivome
Copy link
Collaborator

ivome commented Oct 6, 2019

I just published a new version v0.4.0 with this feature

@ivome ivome closed this as completed Oct 6, 2019
@MichalLytek MichalLytek mentioned this issue Oct 6, 2019
Merged
@snyk-bot snyk-bot mentioned this issue Feb 23, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivome @MichalLytek