Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app to be compatible with https-proxy-agent 7.0.0 #213

Closed
4 of 10 tasks
hello-ashleyintech opened this issue Jun 1, 2023 · 1 comment
Closed
4 of 10 tasks

Update app to be compatible with https-proxy-agent 7.0.0 #213

hello-ashleyintech opened this issue Jun 1, 2023 · 1 comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Milestone
1.x

Comments

@hello-ashleyintech
Copy link
Contributor

Description

Currently, the https-proxy-agent package is on v5.0.1. Dependabot opened a PR (#212) to bump this up two major versions to 7.0.0 - however, this version bump fails the HTTP Proxy unit test that was added to the Slack Send unit tests. It would be great to update this package to the most recent version for security purposes and also adjust the code's use of the package so that it's compatible with the latest version, 7.0.0, and the unit tests pass.

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request) - dependency
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@hello-ashleyintech hello-ashleyintech added enhancement New feature or request good first issue Good for newcomers dependencies Pull requests that update a dependency file labels Jun 1, 2023
@hello-ashleyintech hello-ashleyintech added this to the 1.x milestone Jun 1, 2023
@hello-ashleyintech hello-ashleyintech mentioned this issue Jun 1, 2023
Closed
@hello-ashleyintech hello-ashleyintech linked a pull request Jun 5, 2023 that will close this issue
Bump https-proxy-agent from 5.0.1 to 7.0.0 #212
Closed
@zimeg
Copy link
Member

zimeg commented May 30, 2024

Thanks for tracking this, and thank you @dependabot! Closing with the fix in #241 🚀

@zimeg zimeg closed this as completed May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.x
Development

Successfully merging a pull request may close this issue.

Bump https-proxy-agent from 5.0.1 to 7.0.0 slackapi/slack-github-action
2 participants
@hello-ashleyintech @zimeg