New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add timepicker block element support #876
Conversation
Codecov Report
@@ Coverage Diff @@
## main #876 +/- ##
===========================================
- Coverage 86.63% 75.72% -10.92%
===========================================
Files 95 35 -60
Lines 8776 3394 -5382
===========================================
- Hits 7603 2570 -5033
+ Misses 1173 824 -349
Continue to review full report at Codecov.
|
Hi! Is this PR waiting for TimePicker to be GA? Is there anything blocking its release? |
Yes, it is! If you need this right now, please do copy & paste for now. |
As I mentioned at slackapi/node-slack-sdk#1226 (comment) , we are going to merge this change into the next minor version release. I will update the commit and make this PR ready fro review soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool! 🎉
Summary
This pull request adds
timepicker
block element support. As the element is still in beta, the specification can be changed until its GA release.Category (place an
x
in each of the[ ]
)/docs-src
(Documents, have you run./docs.sh
?)/docs-src-v2
(Documents, have you run./docs-v2.sh
?)Requirements (place an
x
in each[ ]
)python setup.py validate
after making the changes.