Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timepicker block element support #876

Merged
merged 1 commit into from May 7, 2021
Merged

Conversation

seratch
Copy link
Member

@seratch seratch commented Nov 12, 2020

Summary

This pull request adds timepicker block element support. As the element is still in beta, the specification can be changed until its GA release.

Category (place an x in each of the [ ])

  • slack_sdk.web.WebClient (Web API client)
  • slack_sdk.webhook.WebhookClient (Incoming Webhook, response_url sender)
  • slack_sdk.models (UI component builders)
  • slack_sdk.oauth (OAuth Flow Utilities)
  • slack_sdk.rtm.RTMClient (RTM client)
  • slack_sdk.signature (Request Signature Verifier)
  • /docs-src (Documents, have you run ./docs.sh?)
  • /docs-src-v2 (Documents, have you run ./docs-v2.sh?)

Requirements (place an x in each [ ])

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run python setup.py validate after making the changes.

@seratch seratch added this to the 3.1.0 milestone Nov 12, 2020
@seratch seratch self-assigned this Nov 12, 2020
@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #876 (bf3409e) into main (833e3c5) will decrease coverage by 10.91%.
The diff coverage is 100.00%.

❗ Current head bf3409e differs from pull request most recent head 79dca71. Consider uploading reports for the commit 79dca71 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #876       +/-   ##
===========================================
- Coverage   86.63%   75.72%   -10.92%     
===========================================
  Files          95       35       -60     
  Lines        8776     3394     -5382     
===========================================
- Hits         7603     2570     -5033     
+ Misses       1173      824      -349     
Impacted Files Coverage Δ
slack_sdk/models/blocks/__init__.py 100.00% <100.00%> (ø)
slack_sdk/models/blocks/block_elements.py 92.32% <100.00%> (+0.20%) ⬆️
slack_sdk/models/messages/message.py 0.00% <0.00%> (-68.75%) ⬇️
slack_sdk/web/legacy_client.py 35.69% <0.00%> (-60.10%) ⬇️
slack_sdk/oauth/state_store/sqlite3/__init__.py 86.15% <0.00%> (-1.54%) ⬇️
slack_sdk/models/views/__init__.py 90.59% <0.00%> (-1.14%) ⬇️
slack_sdk/models/blocks/basic_components.py 86.22% <0.00%> (-0.91%) ⬇️
...dk/oauth/installation_store/sqlalchemy/__init__.py 96.96% <0.00%> (-0.57%) ⬇️
...k_sdk/oauth/redirect_uri_page_renderer/__init__.py 94.44% <0.00%> (-0.30%) ⬇️
slack_sdk/models/attachments/__init__.py 99.41% <0.00%> (-0.01%) ⬇️
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 833e3c5...79dca71. Read the comment docs.

@seratch seratch modified the milestones: 3.1.0, 3.2.0 Nov 25, 2020
@noqcks
Copy link

noqcks commented Dec 3, 2020

Hi! Is this PR waiting for TimePicker to be GA? Is there anything blocking its release?

@seratch
Copy link
Member Author

seratch commented Dec 4, 2020

@noqcks

Is this PR waiting for TimePicker to be GA?

Yes, it is! If you need this right now, please do copy & paste for now.

@seratch seratch modified the milestones: 3.2.0, 3.3.0 Jan 5, 2021
@seratch seratch modified the milestones: 3.3.0, 3.4.0 Jan 28, 2021
@seratch seratch modified the milestones: 3.4.0, 3.x Feb 11, 2021
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2021

CLA assistant check
All committers have signed the CLA.

@seratch
Copy link
Member Author

seratch commented May 6, 2021

As I mentioned at slackapi/node-slack-sdk#1226 (comment) , we are going to merge this change into the next minor version release. I will update the commit and make this PR ready fro review soon.

@seratch seratch marked this pull request as ready for review May 7, 2021 21:41
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! 🎉

@seratch seratch merged commit 66c8859 into slackapi:main May 7, 2021
@seratch seratch deleted the timepicker branch May 7, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants